Merged
Conversation
jeong1112
requested review from
eraser502 and
hyomee2
and removed request for
hyomee2
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthrough온보딩 및 약관동의 여부 조회 API를 구현합니다. 새로운 엔드포인트를 추가하고 전담 DTO를 생성하며, 기존 상태 응답에서 관련 필드를 제거하고 서비스 로직을 분리합니다. 온보딩 필터의 허용 경로에 새 엔드포인트를 등록합니다. Changes
Sequence Diagram(s)sequenceDiagram
actor Client
participant Controller as MemberController
participant Service as MemberService
participant Repository as Member<br/>Repository
participant VisaRepo as MemberVisa<br/>Repository
Client->>Controller: GET /api/v1/members/completion<br/>(Authentication: memberId)
Controller->>Service: getCompletion(memberId)
Service->>Repository: findById(memberId)
Repository-->>Service: Member 객체
Service->>VisaRepo: findActiveVisaByMemberId(memberId)
VisaRepo-->>Service: MemberVisa 객체
Note over Service: onboardingRequired &<br/>agreeTerm 계산
Service-->>Service: MemberCompletionResponse 생성
Service-->>Controller: MemberCompletionResponse
Controller-->>Client: BaseResponse<br/>(HTTP 200)
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description 📝
onboardingRequired : true를 반환해야 하므로 Filter 검증을 통과하도록 했습니다.ScreenShots 📷
To Reviewers 📢
Summary by CodeRabbit
새로운 기능